Safeguards against accidentally banning staff members

[ionite34]

To avoid any more situations like these:

Propose to add:

⚠️ This action will apply ban to a staff member, @user (User Name #8405). To confirm, rerun the command with --force

[vivekashok1221]

We could have the confirmation as a button instead of a flag.

[CaedenPH]

What about instead of rerunning the command with --force, which may be abused, a confirmation dialog that you click to confirm?

[ChrisLovering]

I like the idea of the button. if the user has one of constants.STAFF_PARTNERS_COMMUNITY_ROLES reply to the user with a warning message and a confirmation button.

[Robin5605]

I would be willing to take this up

[ChrisLovering]

I would be willing to take this up

Sounds good, feel free to self assign

[Robin5605]

yoinked

[ChrisLovering]

FYI, https://bot-core.pythondiscord.com/main/output/botcore.utils.interactions.html#botcore.utils.interactions.ViewWithUserAndRoleCheck might be a good view to subclass as it comes with some nice checks out of the box

[Robin5605]

Maybe. In this case the command itself (!ban) will only run if the use is authorized. After that it's only a simple matter of checking if the interaction user is the same as the one who triggered the command. This is a design decision though. Do we want other moderators to be able to cancel a potential helper ban?