Enhanced user command #1105
Merged
Enhanced user command #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
That looks neat! |
|
Updated with status info |
jb3
added
a: frontend
kwzrd
reviewed
Aug 19, 2020
bot/cogs/information.py
Outdated
Comment on lines
243
to
247
| badges = "" | ||
|
|
||
| for badge, is_set in user.public_flags: | ||
| if is_set and (emoji := getattr(constants.Emojis, f"badge_{badge}")): | ||
| badges += emoji + " " |
There was a problem hiding this comment.
Neat way to use walrus. But I think you want to specify a default for getattr. This way can raise.
I'd probably personally make badges a list & then join the elements on a " ", but this is fine too.
Comment on lines
232
to
235
| emoji = "" | ||
| if activity.emoji: | ||
| if not activity.emoji.id: | ||
| emoji += activity.emoji.name + " " |
There was a problem hiding this comment.
Is the activity.emoji.id check here to filter custom emoji? I think it could use an in-line comment. It's a little indirect.
bot/cogs/information.py
Outdated
Comment on lines
187
to
197
| @staticmethod | ||
| def status_to_emoji(status: Status) -> str: | ||
| """Convert a Discord status into the relevant emoji.""" | ||
| if status is Status.offline: | ||
| return constants.Emojis.status_offline | ||
| elif status is Status.dnd: | ||
| return constants.Emojis.status_dnd | ||
| elif status is Status.idle: | ||
| return constants.Emojis.status_idle | ||
| else: | ||
| return constants.Emojis.status_online |
There was a problem hiding this comment.
Have you considered using a dictionary to define this mapping? This is probably fine, but it feels a little unnatural to me.
MarkKoz
approved these changes
Aug 19, 2020
Comment on lines
+296
to
+297
| for field_name, field_content in fields: | ||
| embed.add_field(name=field_name, value=field_content, inline=False) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new information into the
!usercommand showing user badges & statuses on all different Discord platforms as well as switching our headers out for embed fields.Resolves #1047.