Skip to content

Migrate to og_blurple #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2021
Merged

Migrate to og_blurple #1901

merged 4 commits into from
Nov 1, 2021

Conversation

@TizzySaurus
Copy link
Contributor

@TizzySaurus TizzySaurus commented Oct 21, 2021

Closes #1899.

Migration from discord.Colour.blurple() to discord.Colour.og_blurple().

@TizzySaurus TizzySaurus added a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) p: 3 - low Low Priority t: enhancement Changes or improvements to existing features s: needs review Author is waiting for someone to review and approve labels Oct 21, 2021
jacobmonck
jacobmonck reviewed Oct 22, 2021
View reviewed changes
Copy link
Contributor

@jacobmonck jacobmonck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the files that you have changed it looks good to me. But I haven't really checked any of the other files.

kosayoda
kosayoda requested changes Oct 22, 2021
View reviewed changes
Copy link
Member

@kosayoda kosayoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the failing test to reflect the changed role colour HSV.

Otherwise looks good 👍🏻

@kosayoda kosayoda added s: waiting for author Waiting for author to address a review or respond to a comment and removed s: needs review Author is waiting for someone to review and approve labels Oct 29, 2021
@TizzySaurus
Fix tests
91d08d0
@TizzySaurus
Fix conflicts
df11205 
Removes the old `clean.py` which was superseded by bot#1793
@TizzySaurus
Copy link
Contributor Author

TizzySaurus commented Oct 31, 2021

Please update the failing test to reflect the changed role colour HSV.

Otherwise looks good 👍🏻

Has been fixed 👍

@TizzySaurus TizzySaurus requested a review from kosayoda October 31, 2021 22:40
@Akarys42 Akarys42 added the review: do not merge The PR can be reviewed but cannot be merged now label Nov 1, 2021
@TizzySaurus TizzySaurus removed the review: do not merge The PR can be reviewed but cannot be merged now label Nov 1, 2021
@wookie184 wookie184 enabled auto-merge (squash) November 1, 2021 18:53
wookie184
wookie184 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems fine

@wookie184 wookie184 merged commit e08764a into main Nov 1, 2021
@wookie184 wookie184 deleted the og_blurple-migration branch November 1, 2021 18:53
@Xithrius Xithrius removed the s: waiting for author Waiting for author to address a review or respond to a comment label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobmonck jacobmonck jacobmonck left review comments

@wookie184 wookie184 wookie184 approved these changes

@Akarys42 Akarys42 Awaiting requested review from Akarys42

@Den4200 Den4200 Awaiting requested review from Den4200

@jb3 jb3 Awaiting requested review from jb3

@ks129 ks129 Awaiting requested review from ks129

@mbaruh mbaruh Awaiting requested review from mbaruh mbaruh is a code owner

@MarkKoz MarkKoz Awaiting requested review from MarkKoz MarkKoz is a code owner

@kosayoda kosayoda Awaiting requested review from kosayoda

+1 more reviewer

@vcokltfre vcokltfre vcokltfre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) p: 3 - low Low Priority t: enhancement Changes or improvements to existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to discord.Colour.og_blurple()

8 participants

@TizzySaurus @vcokltfre @wookie184 @kosayoda @jacobmonck @Xithrius @Akarys42