Laudatory Larkspurs #16

janine9vn · 2025-09-13T02:21:20Z

No description provided.

Merge GUI features to main

# Conflicts: # src/commands/load_image.py # src/terminal.py

-Julien

…tory-larkspurs into terminal

-Julien

added some exclusions in toml as well

# Conflicts: # src/utils/color.py

…bd07652c975' git-subtree-dir: laudatory-larkspurs git-subtree-mainline: 49c1216 git-subtree-split: 4ff0614

janine9vn

The Overall Picture

This was a very fun project to test out. Your overall project structure and organization is nicely done. It makes it easy to review and reason about the code. Your project functioned really well and everything was intuitive once you read through the basic commands. Things worked seamlessly which is very impressive given the time constraints. Overall, very well done!

README & Documentation

The README and Documentation are excellent. I think an area of improvement could be adding some example commands for each major feature to try out, or showcase one of the more complex commands. There are a few spots in the code where I think some comments are redundant and some other parts where an additional comment or two would be helpful. Typehints are well done. I think the docstrings on some of the busier functions could be improved a bit and include more information, but otherwise the class docstrings are well done and no other complaints.

Commits

The commits overall look good in terms of scope and messages. There are a few where the messages could be improved though. For instance "bugfixes" or "fixed ping" could be improved by either calling out specific bugs in the commit title or in the body if you need more space to detail things.

Code Quality

Overall the code quality is of a good level. There are a few places where dunders are used when there's more straight-forward syntax that can be used instead. Some formatting every-so-often was a bit odd and I think could be slightly improved. Overall your implementation is very class-heavy, but that's not a bad thing and makes sense with what your project deals with. Some of your functions were heavily indicated as "private" with the leading underscore, but across the project that was inconsistent.

janine9vn · 2025-09-28T14:53:18Z

laudatory-larkspurs/src/commands/base_command.py

+    from terminal import Terminal
+
+
+class BaseCommand:


Have you looked into using the @abc.abstractmethod for this to require functions to be overridden by subclasses instead of the manual raising of the NotImplementedError?
Based on the docstrings for the functions it seems like that may be what you want.

janine9vn · 2025-09-28T14:54:24Z

laudatory-larkspurs/src/commands/background.py

+
+        match len(args):
+            case 0:
+                return " " + str(terminal.background_color.r)


An f-string would be good to use here: return f" {terminal.background_color.r}"

janine9vn · 2025-09-28T14:57:24Z

laudatory-larkspurs/src/commands/draw_circle.py

+        if not (args[2].isdigit()):
+            terminal.output_error("Invalid radius.")
+            return False
+        rad = int(args[2])
+        if rad < 0:
+            terminal.output_error("Radius cannot be negative.")
+            return False


Nice pre-emptive checking!

janine9vn · 2025-09-28T15:04:50Z

laudatory-larkspurs/src/gui/layout.py

+            display: flex;
+            flex-direction: column;
+            width: 100%;
+            height: 100%;


I would indent this a level so it doesnt look like args to the init directly. I did a double take to see if there was a misplace " before I realized what the intent was.

janine9vn · 2025-09-28T15:07:00Z

laudatory-larkspurs/src/gui/components/terminal_io.py

+        if command_verb:
+            self.text += command_verb.group(1)
+
+            command_verb_span.text = command_verb.group(2)
+            self.append_child(command_verb_span)
+
+            command_end = text[len(command_verb.group(0)) :]
+            command_end_span = Element(tag_name="span")
+            command_end_span.text = command_end
+            self.append_child(command_end_span)


Either in the docstring or as a comment, some more context about the approach and the intent could be helpful.

Something like: If it's a command verb then we ...

janine9vn · 2025-10-13T01:34:22Z

laudatory-larkspurs/src/gui/components/image_display_manager.py

+        natural_width = self.image_element["naturalWidth"]
+        natural_height = self.image_element["naturalHeight"]
+        intrinsic_mouse_x = int(
+            ((event.clientX - self.image_element["offsetLeft"]) / self.image_element["clientWidth"]) * natural_width,


Small formatting thing, but I prefer this to be formatted like: ((event.ClientX - self.image_element["offsetLeft"])/self.image_element["clientWidth"])*natural_width
It's a bit easier to parse with the precedence of the operators and brings it closer into alignment with PEP8

janine9vn · 2025-10-13T01:40:24Z

laudatory-larkspurs/src/gui/components/terminal_gui.py

+        else:
+            print("Warning: TerminalGui has no Terminal instance assigned.")


Would this be worth raising an actual warning or error for?

janine9vn · 2025-10-13T01:41:54Z

laudatory-larkspurs/src/gui/components/terminal_input.py

+    def set_value(self, value: str) -> None:
+        """Set the value of the text input."""
+        self.text_input["value"] = value
+        command = re.search(r"^(\s*)(\S+\b)", value)


A comment here to help explain the intent of the regex would be helpful.

janine9vn · 2025-10-13T01:46:23Z

laudatory-larkspurs/src/utils/color.py

+    match = re.search(rf"^(\d+){sep}(\d+){sep}(\d+)(?:{sep}(\d+))?$", color_string) or re.search(
+        rf"^rgba?\((\d+){sep}(\d+){sep}(\d+)(?:{sep}(\d+))?\)$",
+        color_string,
+    )


I would format this a bit different for easier readability, something like this so that the regexes are a bit easier to compare to see what they're doing:

match = re.search( rf"^(\d+){sep}(\d+){sep}(\d+)(?:{sep}(\d+))?$", color_string ) or re.search( rf"^rgba?$(\d+){sep}(\d+){sep}(\d+)(?:{sep}(\d+))?$$", color_string, )

janine9vn · 2025-10-13T01:47:40Z

laudatory-larkspurs/src/utils/color.py

+    return Color(int(r), int(g), int(b), a if a else 255)
+
+
+colors = {


Are these pre-defined colors shown the user via the help command at some point? If not, that would be a good improvement to make.

jon-edward and others added 30 commits August 9, 2025 20:12

Add command suggestion and autocomplete mechanism

34d69cb

Add terminal output with color; fix linting errors

d133706

pillow package

3a44fe9

Merge pull request #6 from Miras3210/gui

269439c

Merge GUI features to main

lint fix

8503241

fixed comments, added load_image command

992216a

fixed comments, added load_image command

42f1fe1

Merge remote-tracking branch 'origin/terminal' into terminal

6c38260

# Conflicts: # src/commands/load_image.py # src/terminal.py

fixed linting issues

0e8c3da

fixed docstring in load image

99369c4

prevent the user to select text while dragging the separator

d2283c3

-Julien

Merge branch 'terminal' of https://github.com/Miras3210/codejam-lauda…

e6262b6

…tory-larkspurs into terminal

prevent the user from selecting any text while dragging the separator

39679e2

-Julien

added color class

78db669

Changed Utils package name to utils

4b0389b

Added Color to as type to areas of the codebase

08c2ab8

Added Docstrings to color

e85a979

Added return types to color

69d87a6

added a bunch of color types

df8b1a1

Added import for pillow for pyodide

f62c20c

Update PIL for lockfile

91341cf

Modularize app colors

3dd7f21

Merge remote-tracking branch 'origin/terminal' into terminal

c44ce36

Fix selection CSS, fix incorrect focus on text selection

ce11dd9

Added terminal and image creation to gui init

00aaecd

no more colors, too many ruff errors

af16869

Fixed circular import issue with terminal

d5339bf

Fixed linter issues in color

82a1949

added some exclusions in toml as well

Merge remote-tracking branch 'origin/terminal' into terminal

ff0c304

# Conflicts: # src/utils/color.py

Auto fix end of file

0c102c3

Miras3210 and others added 29 commits August 21, 2025 21:29

Contributors :D

6e83f8a

Commands description and Contributors image

410f84c

Added Philip's contribution to docs

032b3de

Jont contributions

eb855aa

docs: Add flexible alerts plugin to index.html

df809e1

docs: Reorganize project structure to be up to date

99d9604

docs: Add project description to README

b696b17

docs: Add project details

91e2976

docs: Update installation guide

3f33713

docs: Update contribution guidelines

c35bf33

docs: Update cover page

0868364

docs: Add information on Code Jam

ca764f8

docs: Create documentation on color formats

0f87aec

docs: Update commands to include arguments

eed17e9

docs: Remove duplicate code-jam-12.md

324c834

Remove sample files

96ae4e6

docs: Add Get Started page to navbar

58a5414

docs: Add Color Formats to navbar

71d98a9

docs: Add Features to navbar

30aea60

docs: Add version 0.1.0 and update navbar labels

7c6689a

Add Julien to contribution.md

4927ba6

docs: Add workflow badges to README

5a884c3

Added link for named CSS colors to docs

b37a20d

Merge remote-tracking branch 'origin/main'

dbed01e

docs: Add FAQ section

0578b5d

Update README.md

4826e9d

docs: Update docs/README.md

29221fd

Added webcolors to packages doc

4ff0614

Add 'laudatory-larkspurs/' from commit '4ff0614197a73fd689844ef246987…

6fe2927

…bd07652c975' git-subtree-dir: laudatory-larkspurs git-subtree-mainline: 49c1216 git-subtree-split: 4ff0614

janine9vn commented Oct 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Laudatory Larkspurs #16

Laudatory Larkspurs #16

Uh oh!

janine9vn commented Sep 13, 2025

Uh oh!

janine9vn left a comment

Uh oh!

janine9vn Sep 28, 2025

Uh oh!

janine9vn Sep 28, 2025

Uh oh!

janine9vn Sep 28, 2025

Uh oh!

janine9vn Sep 28, 2025

Uh oh!

janine9vn Sep 28, 2025

Uh oh!

janine9vn Oct 13, 2025

Uh oh!

janine9vn Oct 13, 2025

Uh oh!

janine9vn Oct 13, 2025

Uh oh!

janine9vn Oct 13, 2025

Uh oh!

janine9vn Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

		else:
		print("Warning: TerminalGui has no Terminal instance assigned.")

		return Color(int(r), int(g), int(b), a if a else 255)


		colors = {

Uh oh!

Laudatory Larkspurs #16

Are you sure you want to change the base?

Laudatory Larkspurs #16

Uh oh!

Conversation

janine9vn commented Sep 13, 2025

Uh oh!

janine9vn left a comment

Choose a reason for hiding this comment

The Overall Picture

README & Documentation

Commits

Code Quality

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants