Update django_simple_bulma.py#36
Closed
krlan wants to merge 1 commit into
Closed
Conversation
No static templatetag in newer versions
Owner
|
Hey @krlan, thanks for the PR! Do you know if this breaks compatibility with older versions of Django? Looks like the build is currently failing with this error:
Could you have a look at this and see if you can get the build passing? |
Closed
MarkKoz
suggested changes
Dec 19, 2019
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
Per the discussion #37 (comment), it's recommend and more convenient to use django.templatetags.static.static() instead.
Owner
|
We merged #38 instead, which seems to have the prefered solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No static templatetag in newer versions