Add support for multiple themes #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
Author
|
The checks are failing on code I didn't introduce |
Owner
Looks like it's just the trailing whitespace checker. Why don't you set up the |
Owner
|
To be perfectly clear, even though this PR didn't introduce this code, it's fine if you make a kaizen commit that fixes some trailing whitespace. |
lemonsaurus
approved these changes
Aug 18, 2020
Owner
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
This looks reasonable. Your code is, as usual, quite good. Nice work.
I should probably test it before merging.
lemonsaurus
approved these changes
Nov 9, 2020
Owner
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
Seems to work. I'll merge and release it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #46
It basically generates a unique bulma.css stylesheet for each theme. I also decided that we should log a warning if someone tries to use a theme they haven't defined.