Release v1.1.1#40
Merged
Merged
Conversation
Now only necessary for Python < 3.8
Add version-specific parsing of src file that was missed in FunctionVisitor helper method
Add .tox dirs to flake8 exclusion
* Consolidate testing & coverage into a single step * Combine coverage across build environments * Add explicit importlib-metadata to prevent downstream ModuleNotFound errors * Update to Ubuntu 18.04 * Add Python 3.8 environment
Owner
Author
|
Opening this up for review. Testing passes locally & Python 3.8 support in CI will be here soonTM. |
We're probably ok allowing for minor versions of flake8 to be installed. Since `~=` isn't recognized by `pipenv-setup` we have to define this as a range instead.
Owner
Author
|
3.8 is now (unofficially) present on Azure 🎉 |
Splitting the test parameters across multiple files makes test specification fairly fragile and difficult to both maintain and add additional cases to. This refactor migrates test case source & truth parameters into a single file, allowing test cases to be specified in one place and in discrete chunks, removing the risk that adjusting one test case negatively impacts testing on the unchanged test cases. The test fixtures have also been adjusted to accommodate the change in test parameter layout.
So I don't completely miss tests again And because it's a super good idea
* Fix classifier logic only flagging mixed type hints if the type comment is first. This was due to only using a sentinel flag for the type comment instead of both the comment & annotation * Add test case for the type annotation coming before the type comment * Modify mixed type hint test to check that TYP301 is only being yielded once per function & add a test case * Rename type comment test to better describe what is being tested
* Fix TYP301 classification issue where error is not yielded if the first argument is type annotated and the remaining arguments have type comments * Fix misnamed mixed type test so it actually runs * Add test for single TYP301 yield per function
Owner
Author
|
I've merged in some of the refactoring being undertaken as part of #50 to fix some bugs that were identified on this release branch. The summary in the OP has been updated. |
Handling for test skipping is also provided to prevent test from failing in Python versions older than 3.8
MarkKoz
suggested changes
Dec 1, 2019
MarkKoz
approved these changes
Dec 2, 2019
SebastiaanZ
approved these changes
Dec 8, 2019
SebastiaanZ
left a comment
SebastiaanZ
left a comment
There was a problem hiding this comment.
Looks good to me.
I've read the source code a few times, ran the test suite locally (although I don't have P3.6, so that was skipped), and did some manual testing as well. I do want to note that I'm a bit out of my comfort zone reviewing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for v1.1.1 release
Added
pipenv-setupas a dev dependency & CI check to ensure synchronization betweenPipfileandsetup.pyChanged
typed_astis now required only for Python versions< 3.83.7.9for Python 3.8 compatibilityFixed
TYP301classification issue where error is not yielded if the first argument is type annotated and the remaining arguments have type commentsCloses: #44
Closes: #45
Closes: #46
Closes: #43