Fix Tox test execution on Windows#66
Merged
Merged
Conversation
Owner
|
Thanks! I've been doing all the dev on MacOS so I never ran into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the tests is not currently possible on Windows, and will fail with
ERROR: InvocationError for command could not find executable python3. This is because Tox executespytestusingpython3, which isn't a valid python command on Windows. Since the Tox runs the tests in a virtual environment, plainpythoncan be safely used.Tested against Python 3.6 and 3.6 on Windows (PowerShell) and 3.7 in Ubuntu (WSL).