Conversation
To help provide compatibility with Mypy for maintainers that wish to do so, the `--mypy-init-return` flag has been introduced to mimic Mypy's allowance for the omission of return type hints for __init__ methods that are not dynamically typed (at least one argument is annotated).
MarkKoz
suggested changes
Jul 10, 2020
Contributor
MarkKoz
left a comment
There was a problem hiding this comment.
You forgot to update the version in pyproject.toml
Co-authored-by: Mark <kozlovmark@gmail.com>
Oops Co-authored-by: Mark <kozlovmark@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
[v2.3.0]
Added
--mypy-init-returnto allow omission of a return type hint for__init__if at least one argument is annotated.Additional Details
To help provide compatibility with Mypy for maintainers that wish to do so, the
--mypy-init-returnflag has been introduced to mimic Mypy's allowance for the omission of return type hints for__init__methods that are not dynamically typed (at least one argument is annotated). With this flag set,ANN200level errors will be suppressed for__init__methods if at least one argument is explicitly annotated.For example, from Mypy's documentation:
NOTE: By default, Mypy does not enforce annotations for
selfin class methods, so to completely mimic Mypy's behavior withflake8-annotationsANN101will need to be added to the repository's ignored linting codes.See Mypy's documentation for additional details: https://mypy.readthedocs.io/en/stable/class_basics.html?#annotating-init-methods
Closes #87