Add rolling window logic to the rate limit #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb3
previously approved these changes
May 29, 2021
ChrisLovering
previously approved these changes
May 29, 2021
New headers: - Requests-Remaining: (int) amount of interactions remaining. - Requests-Limit: (int) maximum amount of interactions that can be done in the same period - Requests-Period: (int) duration, in second, of a period - Requests-Reset: (float) duration, in second, before getting all the interactions back
Contributor
Author
|
New headers:
|
pixels/utils/ratelimits.py
Outdated
| response.headers.append("Requests-Remaining", str(remaining_requests)) | ||
| response.headers.append("Requests-Limit", str(self.LIMITS.requests)) | ||
| response.headers.append("Requests-Period", str(self.LIMITS.time_unit)) | ||
| response.headers.append("Requests-Reset", str(request_reset)[5:]) |
Member
There was a problem hiding this comment.
Suggested change
| response.headers.append("Requests-Reset", str(request_reset)[5:]) | |
| response.headers.append("Requests-Reset", str(request_reset)[:6]) |
Co-authored-by: Chris <chris.lovering.95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a rolling window logic as described in #91.
Closes #91.