Generic Movie Embed Generator#306
Closed
sgh304 wants to merge 2 commits into
Closed
Conversation
Contributor
|
I'm a fan of this approach with one slight tweak: rather than having a utility function, can you move this into an movie recommendation Evergreen cog so we can get movie recommendations year-round? The seasonal-specific commands should still be able to call it with their specific genre flags. With the above in mind, it should be fine to include #213 with this PR. |
Contributor
|
Can I take this development over due current currently this development is pretty dead? |
Contributor
|
This PR does look stale and I think it's okay for someone else to take over the development at this point. |
Contributor
|
More or less superseded by #350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic Movie Embed Generator
Adds a generic method for generating random movie embeds.
Pull Request Details
This abstracts out the logic from the Valentine's Day movie generation command into a util function.
This will make creating new movie generation commands easier, making them just a function call with different parameters. I've gone ahead and converted the existing
romancemoviecommand to use this new function. I also plan to use this framework in a future PR to tackle issue #213.