Skip to content

Python Bot help command adding to SeasonalBot#367

Closed
ks129 wants to merge 3 commits into
python-discord:masterfrom
ks129:help-command
Closed

Python Bot help command adding to SeasonalBot#367
ks129 wants to merge 3 commits into
python-discord:masterfrom
ks129:help-command

Conversation

@ks129
Copy link
Copy Markdown
Contributor

@ks129 ks129 commented Mar 2, 2020

Relevant Issues

Closes #295

Description

I copy-pasted help command from Python bot and made this working in SeasonalBot. Added loading to __main__.py, ignoring to SeasonalBot.load_extensions.

Reasoning

Due there is issue about it, what is approved.

Screenshots

Screenshot 2020-03-02 at 17 26 31
Not going to add more screenshots. It's same help command what is in Python bot.

Did you:

  • Join the Python Discord Community?
  • If dependencies have been added or updated, run pipenv lock?
  • Lint your code (pipenv run lint)?
  • Set the PR to allow edits from contributors?

@ks129 ks129 requested a review from a team as a code owner March 2, 2020 15:28
@eivl
Copy link
Copy Markdown
Contributor

eivl commented Mar 3, 2020

Commit history does not show that you copy-pasted and then made changes. it shows a made-changes version you copy-pasted in.

Comment thread bot/help.py
else:
title = self.title

embed.set_author(name=title)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the change between this and the original?

@sco1 sco1 added the status: waiting for author Waiting for author to address a review or respond to a comment label Mar 5, 2020
@ks129
Copy link
Copy Markdown
Contributor Author

ks129 commented Mar 7, 2020

I'll close this now, due I started working in new branch, where I added better information. New PR after close.

@ks129 ks129 closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting for author Waiting for author to address a review or respond to a comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Pagination to .help

3 participants