Skip to content

Hackstats: fix time and date specifics#511

Merged
Akarys42 merged 2 commits into
python-discord:masterfrom
hedyhli:hackto-dates
Oct 24, 2020
Merged

Hackstats: fix time and date specifics#511
Akarys42 merged 2 commits into
python-discord:masterfrom
hedyhli:hackto-dates

Conversation

@hedyhli
Copy link
Copy Markdown
Contributor

@hedyhli hedyhli commented Oct 23, 2020

Description

  • Updated PRs 'created' time range to the range @MattIPv4 told me
  • updated categorising prs logic, now PRs that are after the review period but created before october 3rd will count

Reasoning

for some people the PRs listed wasn't the same as the ones on the website, those PRs are the ones from before october 3rd, and passed review period. Now it's listed

Screenshots

Before/after
345B6A06-7130-4372-A7FA-22D4A6053B76
3187CF34-7CF2-4DA9-A60C-39812D86C95A

Did you:

  • Join the Python Discord Community?
  • If dependencies have been added or updated, run pipenv lock?
  • Lint your code (pipenv run lint)?
  • Set the PR to allow edits from contributors?

@hedyhli hedyhli requested a review from a team as a code owner October 23, 2020 09:07
@hedyhli hedyhli requested review from Senjan21 and dementati October 23, 2020 09:07
@ghost ghost added the needs 2 approvals label Oct 23, 2020
@ghost ghost removed the needs 1 approval label Oct 24, 2020
@Akarys42 Akarys42 merged commit c781397 into python-discord:master Oct 24, 2020
Comment thread bot/exts/halloween/hacktoberstats.py
@hedyhli hedyhli deleted the hackto-dates branch October 18, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants