fix(testing): handle uvicorn SystemExit in EllarUvicornServer startup #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading uvicorn, the test server was failing because uvicorn now calls sys.exit(1) when encountering port binding errors. This caused the entire test process to terminate instead of handling errors gracefully. Changes: - Override startup() method to catch SystemExit exceptions - Convert SystemExit to RuntimeError with descriptive message - Ensure proper cleanup via lifespan.shutdown() on errors - Remove setup_event_loop() call that interfered with running loop - Fix _startup_done event synchronization This allows tests to handle server startup failures properly without terminating the test process. Fixes socket_io test failures in TestGatewayWithGuards and related test classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading uvicorn, the test server was failing because uvicorn now calls sys.exit(1) when encountering port binding errors. This caused the entire test process to terminate instead of handling errors gracefully.
Changes:
This allows tests to handle server startup failures properly without terminating the test process.
Fixes socket_io test failures in TestGatewayWithGuards and related test classes.