Skip to content

Conversation

nejch
Copy link
Member

@nejch nejch commented Nov 22, 2023

Changes

See https://docs.gitlab.com/ee/api/draft_notes.html

Not returning anything in the publish methods as we only get a 204 from gitlab, see below:
https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/api/draft_notes.rb#L215-261

Documentation and testing

Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #2728 (a4b28b0) into main (428b4fd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
+ Coverage   96.45%   96.47%   +0.01%     
==========================================
  Files          88       89       +1     
  Lines        5787     5812      +25     
==========================================
+ Hits         5582     5607      +25     
  Misses        205      205              
Flag Coverage Δ
api_func_v4 82.45% <76.00%> (-0.03%) ⬇️
cli_func_v4 83.49% <76.00%> (-0.04%) ⬇️
unit 88.19% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gitlab/client.py 98.58% <100.00%> (+<0.01%) ⬆️
gitlab/v4/objects/__init__.py 100.00% <100.00%> (ø)
gitlab/v4/objects/draft_notes.py 100.00% <100.00%> (ø)
gitlab/v4/objects/merge_requests.py 89.04% <100.00%> (+0.15%) ⬆️

@nejch nejch requested a review from max-wittig November 27, 2023 13:48
@max-wittig max-wittig enabled auto-merge (squash) November 27, 2023 20:29
auto-merge was automatically disabled November 27, 2023 20:31

Pull Request is not mergeable

@max-wittig max-wittig merged commit ebf9d82 into main Nov 28, 2023
@max-wittig max-wittig deleted the feat/draft-notes branch November 28, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants