fix(api): return the new commit when calling cherry_pick

[mschoettle]

Changes

Returns the response when calling ProjectCommit.cherry_pick.

Documentation and testing

Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:

• Documentation in the matching docs section
• Unit tests and/or functional tests

Fixes #3096

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (939505b) to head (e1ba01b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3097      +/-   ##
==========================================
+ Coverage   96.72%   96.77%   +0.04%     
==========================================
  Files          96       96              
  Lines        6293     6293              
==========================================
+ Hits         6087     6090       +3     
+ Misses        206      203       -3     

Flag	Coverage Δ
api_func_v4	82.82% <100.00%> (-0.05%)	⬇️
cli_func_v4	83.01% <50.00%> (ø)
unit	89.25% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
gitlab/v4/objects/commits.py	98.79% <100.00%> (+3.61%)	⬆️

[nejch]

Thanks a lot @mschoettle, makes sense! I think this must be very old code.

Would you mind adding a test for this, maybe just in the functional tests if it's easier than mocking? I know we didn't have one before, but just in case. Let me know if you need help.

[mschoettle]

@nejch Thanks! I noticed yesterday that there were no tests for cherry_pick so I started adding a unit test and functional test based on the existing tests.

I am having an issue with running the functional tests in the codespace so I am relying on the pipeline for those.

[nejch]

Thanks @mschoettle for adding the tests as well! Looks great. This should be released tonight with the schedule.