Rename 'hyper-h2' to simply 'h2' #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
commented
Feb 21, 2021
| ======= | ||
|
|
||
| ``hyper-h2`` is maintained by Cory Benfield, with contributions from others. | ||
| ``h2`` was authored by Cory Benfield and is maintained |
Member
Author
There was a problem hiding this comment.
Changed this section to more accurately reflect the maintainership of the package
sethmlarson
commented
Feb 21, 2021
| .. code-block:: console | ||
| $ pip install h2 | ||
| $ python -m pip install h2 |
Member
Author
There was a problem hiding this comment.
Changed $ pip to $ python -m pip in line with PyPA best practices
sethmlarson
force-pushed
the
rename-h2
branch
from
5e5db80 to
870202f
Compare
Kriechi
reviewed
Feb 21, 2021
Member
|
Overall 👍 Please add a changelog entry to mention the github repo rename, and the fact that the python package name is unchanged. One thing we should watch out for, and have to be careful about, is when talking about h2 the project in close proximity to ALPN and the h2 spec itself. This might require some more explicit language, e.g., "the h2 project". |
Member
Author
|
@Kriechi Renamed the RTD, added a changelog entry (is this the right place? not a bug fix or API change) and remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1245
I went the simple approach of changing
[hH]yper-h2->h2for all code occurrences, the only case I found we'd want to keephyper-h2is Read the Docs for now, but maybe those can be changed to usepython-hyper.org?