Also accept dictionaries as ‘query=’ arguments #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 97.73% 97.75% +0.02%
==========================================
Files 6 6
Lines 1105 1116 +11
Branches 134 135 +1
==========================================
+ Hits 1080 1091 +11
Misses 13 13
Partials 12 12
Continue to review full report at Codecov.
|
The URL constructor and the .replace() method now sensibly handle
dictionaries passed to the ‘query’ argument, instead of strictly
requiring it to be an iterable of (key, value) pairs (both of which
must be strings).
Examples:
URL(query={"foo": "bar"})
url.replace(query={"foo": "bar"})
This simplifies the API for the common use case, in which:
- the order of the items does not matter
(though Python >= 3.6 preserves dictionary order)
- no duplicate parameters are present
Updated the docs to include an example of this.
Fixes #50.
mahmoud
approved these changes
Dec 12, 2017
Member
mahmoud
left a comment
mahmoud
left a comment
There was a problem hiding this comment.
LGTM. I think there's a bit of extra docstring under replace but I'll handle that. Thanks so much!
Contributor
Author
|
you're welcome! not sure what you're referring to re. the docstring, but now that i look at the docstring lines touched in this pr, the "tuple" type definition was never correct since other types worked as well, and now that's even more flexible with transparent dict handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL constructor and the
.replace()method now sensibly handledictionaries passed to the ‘query’ argument, instead of strictly
requiring it to be an iterable of
(key, value)pairs (both of whichmust be strings).
Examples:
This simplifies the API for the common use case, in which:
(though Python >= 3.6 preserves dictionary order)
Updated the docs to include an example of this.
Fixes #50.