Update #170
Merged
Update #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest h11 events are frozen dataclasses and hence the headers can't be overwritten.
Python 3.6 reached End Of Life a month ago.
These are now preset as h11 is typed.
Kriechi
reviewed
Feb 19, 2022
| 'Programming Language :: Python :: Implementation :: PyPy', | ||
| ], | ||
| install_requires=[ | ||
| "dataclasses ; python_version < '3.7'", |
Member
There was a problem hiding this comment.
Is there a specific incompatibility with dataclasses on 3.6 that makes it easier to simply drop 3.6 and move to "native" 3.7?
Member
Author
There was a problem hiding this comment.
dataclasses was added to the stdlib in 3.7
Member
There was a problem hiding this comment.
yes, my question was actually: why drop support for 3.6?
or was this needed to fix the compatibility with h11?
Member
Author
There was a problem hiding this comment.
oh right. 3.6 is now unsupported, https://endoflife.date/python. h11 will drop 3.6 in the next release as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H11, and python versions
fixes #169