fix: Multibind scopes #284
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 95.84% 95.98% +0.13%
==========================================
Files 1 1
Lines 602 623 +21
Branches 103 106 +3
==========================================
+ Hits 577 598 +21
Misses 19 19
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eirikur-nc
commented
Oct 12, 2025
Comment on lines
-390
to
+414
| _BindingBase = namedtuple('_BindingBase', 'interface provider scope') | ||
| @dataclass | ||
| class _BindingBase: | ||
| interface: type | ||
| provider: Provider | ||
| scope: Type['Scope'] |
There was a problem hiding this comment.
In order to get more type-checking confidence in my work, I converted this named tuple to a dataclass.
eirikur-nc
commented
Oct 12, 2025
Comment on lines
+27
to
+43
| TYPE_CHECKING, | ||
| Any, | ||
| Callable, | ||
| cast, | ||
| Dict, | ||
| Generator, | ||
| Generic, | ||
| get_args, | ||
| Iterable, | ||
| List, | ||
| Optional, | ||
| overload, | ||
| Set, | ||
| Tuple, | ||
| Type, | ||
| TypeVar, | ||
| TYPE_CHECKING, | ||
| Union, | ||
| cast, | ||
| get_args, | ||
| overload, |
There was a problem hiding this comment.
Imports got sorted when I ran black
eirikur-nc
commented
Oct 12, 2025
Comment on lines
-820
to
+847
| def get(self, unused_key: Type[T], provider: Provider[T]) -> Provider[T]: | ||
| def get(self, key: Type[T], provider: Provider[T]) -> Provider[T]: |
There was a problem hiding this comment.
Drive-by: fix invalid override (keyword arguments must match that of the method being overridden).
eirikur-nc
commented
Oct 12, 2025
Comment on lines
+32
to
46
| AssistedBuilder, | ||
| Binder, | ||
| CallError, | ||
| CircularDependency, | ||
| ClassAssistedBuilder, | ||
| ClassProvider, | ||
| Error, | ||
| Inject, | ||
| Injector, | ||
| InstanceProvider, | ||
| InvalidInterface, | ||
| Module, | ||
| NoInject, | ||
| ProviderOf, | ||
| Scope, |
There was a problem hiding this comment.
I ran black on this file as well, which caused the imports to be sorted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change how the
scopeargument of themultibindmethod works, so that it applies to the target rather than the containing list or dictionary. Also, consider explicit class bindings when resolving multibindings, and honor the scope of the class binding when the multibinding has no scope.Why
So that it becomes possible to control the scope of individual multi-bindings. E.g.
Closes #283