Refactor error formatting, show parse error cause #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move error formatting into a dedicated module
- Add a new 'minimal' output mode to describe how we show detail on a
parse error -- and in theory, other well-known errors
- Unlike the previous behavior, the 'minimal' format includes
presentation of the `__cause__`
As a result, the output on a parse error will now include a one-line
presentation of the underlying error.
Ancillary things:
- Fix type annotations for the new interface: use `Literal`s
- Fix type annotations caused by `__cause__` handling (use
`BaseException`)
- Fix some changelog formatting
resolves python-jsonschema#581
sirosen
force-pushed
the
show-stringified-parse-errors
branch
from
b3d7e4e to
2280a40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse error -- and in theory, other well-known errors
presentation of the
__cause__As a result, the output on a parse error will now include a one-line
presentation of the underlying error.
Ancillary things:
Literals__cause__handling (useBaseException)resolves #581