Requests don't seem to have a timeout configured

[lalvarezguillen]

I don't think the requests calls have a timeout configured. We should use a sane timeout. Maybe make it configurable as well

[bitmario]

Seems like there is no timeout indeed (daemon, wallet).

It's definitely useful and I agree it should be configurable. However, I think we should maintain backwards compatibility and not time out by default, but only when the user specifies it when creating a JSONRPCDaemon/JSONRPCWallet object.

I think we should also add a warning stating that a timeout doesn't mean that the requested operation did not/will not succeed, since users could overlook this in dangerous cases (e.g. retrying a timed out transfer without additional checks).

[lalvarezguillen]

good points

[lalvarezguillen]

I guess we can close this now