Skip to content

Conversation

@jfinkhaeuser
Copy link
Contributor

See the Fixed Fields section of the specs, towards the end:

A parameter MUST contain either a schema property, or a content property, but not both.

Adding the oneOf constraint requiring either content or schema fixes this issue.

The same issue applies to all objects that refer to Parameter Objects as their basis, such as e.g. Header Objects. I will add to this branch until I've adjusted all of those, and notify when this is done.

the end of the section, a Parameter Object MUST contain either a
'schema' property or a 'content' property (but not both).
@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files          11       11           
  Lines         326      326           
=======================================
  Hits          310      310           
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7308f07...1c25ece. Read the comment docs.

@jfinkhaeuser
Copy link
Contributor Author

Actually, it seems as if Parameter and Header objects are it. So this should do the trick.

@jfinkhaeuser
Copy link
Contributor Author

The build failure appears to be due to pyflakes:

../../../virtualenv/python3.3.6/lib/python3.3/site-packages/pyflakes/checker.py:1198: in LAMBDA
    args.append(wildcard if PY2 else wildcard.arg)
E   AttributeError: 'str' object has no attribute 'arg'

@p1c2u
Copy link
Collaborator

p1c2u commented Jun 5, 2018

@jfinkhaeuser thank you for the contribution. LGTM

@p1c2u p1c2u merged commit 881a98a into python-openapi:master Jun 5, 2018
@jfinkhaeuser jfinkhaeuser deleted the openapi3-schema-fixes branch June 5, 2018 15:53
@jfinkhaeuser
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants