difference in days is incorrect across daylight savings

[davluangu]

The date difference between 3/13/2017 and 3/12/2017 is 0 days (it should be 1 day)

Reproducible code:

start = pendulum.create(2017, 3, 12, 0, 0, 0, tz='America/Los_Angeles')
for d in range(3):
    end = start.add(days=d)
    day_diff = end.diff(start).in_days()
    print('{} minus {} is {} days'.format(end, start, day_diff))

output:

2017-03-12T00:00:00-08:00 minus 2017-03-12T00:00:00-08:00 is 0 days
2017-03-13T00:00:00-07:00 minus 2017-03-12T00:00:00-08:00 is 0 days
2017-03-14T00:00:00-07:00 minus 2017-03-12T00:00:00-08:00 is 1 days

python 3.5.2
pendulum==1.3.0
Mac OS 10.12.6

[sdispater]

Thanks for reporting this.

It's a bug in the in_days() method, which uses the number of seconds in the period. You will actually get the correct number of days by using the remaining_days property.

I will see how to fix this.

[sdispater]

It's fixed in commit db0f836.

It will land in the next bugfix release.