When creating without tzinfo, preserve fold value. #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new Pendulum instance without passing in a TimezoneInfo object and using python 3.6, the internal fold parameter was not correct. In this scenario, self._fold was being set based on the fold parameter in the underlying datetime object. When using python3.6, this value exists, but is always set to 0 since Pendulum is not passing the fold parameter to the constructor. - Changed self._fold to always be set based on the internal fold variable. - Added checks to the existing unit tests to verify that the fold parameter is being preserved.
Collaborator
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new Pendulum instance without passing in a TimezoneInfo object and using python 3.6, the internal fold parameter was not correct. In this scenario, self._fold was being set based on the fold parameter in the underlying datetime object. When using python3.6, this value exists, but is always set to 0 since Pendulum is not passing the fold parameter to the datetime constructor.
All tests pass with python 3.6.1, did not test with any other versions.