Skip to content

Allow pendulum comparison to None. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2016
Merged

Allow pendulum comparison to None. #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pendulum/pendulum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2139,6 +2139,9 @@ def _get_datetime(self, value, pendulum=False):

:rtype: datetime or Pendulum
"""
if value is None:
return None

if isinstance(value, Pendulum):
return value._datetime if not pendulum else value

Expand Down
5 changes: 5 additions & 0 deletions tests/pendulum_tests/test_comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ def test_not_equal_with_timezone_true(self):
self.assertNotEqual(d1, d2)
self.assertEqual(d1, d3)

def test_not_equal_to_none(self):
d1 = Pendulum(2000, 1, 1, 1, 2, 3)

self.assertNotEqual(d1, None)

def test_greater_than_true(self):
d1 = Pendulum(2000, 1, 1)
d2 = Pendulum(1999, 12, 31)
Expand Down