Skip to content

Add validation for days of the week. #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2016
Merged

Add validation for days of the week. #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c60147
Add validation for days of the week.
kleschenko Oct 29, 2016
3b3e2da
Use cls._days instead of range.
kleschenko Oct 30, 2016
991905e
Add tests for invalid values.
kleschenko Oct 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pendulum/pendulum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,8 @@ def set_week_starts_at(cls, value):

:type value: int
"""
if value not in cls._days:
raise ValueError('Invalid day of the week: {}'.format(value))
cls._week_starts_at = value

@classmethod
Expand All @@ -787,6 +789,8 @@ def set_week_ends_at(cls, value):

:type value: int
"""
if value not in cls._days:
raise ValueError('Invalid day of the week: {}'.format(value))
cls._week_ends_at = value

@classmethod
Expand All @@ -799,13 +803,17 @@ def get_weekend_days(cls):
return cls._weekend_days

@classmethod
def set_weekend_days(cls, value):
def set_weekend_days(cls, values):
"""
Set weekend days.

:type value: list
"""
cls._weekend_days = value
for value in values:
if value not in cls._days:
raise ValueError('Invalid day of the week: {}'
.format(value))
cls._weekend_days = values

# Normalization Rule
@classmethod
Expand Down
9 changes: 9 additions & 0 deletions tests/pendulum_tests/test_day_of_week_modifiers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@

class DayOfWeekModifiersTest(AbstractTestCase):

def test_set_weekend_days_invalid_value(self):
self.assertRaises(ValueError, Pendulum.set_weekend_days, [7])

def test_get_weekend_days(self):
self.assertEqual(
[pendulum.SATURDAY, pendulum.SUNDAY],
Expand All @@ -21,11 +24,17 @@ def test_get_weekend_days(self):
)
Pendulum.set_weekend_days([pendulum.SATURDAY, pendulum.SUNDAY])

def test_set_week_ends_at_invalid_value(self):
self.assertRaises(ValueError, Pendulum.set_week_ends_at, 7)

def test_get_week_ends_at(self):
Pendulum.set_week_ends_at(pendulum.SATURDAY)
self.assertEqual(Pendulum.get_week_ends_at(), pendulum.SATURDAY)
Pendulum.set_week_ends_at(pendulum.SUNDAY)

def test_set_week_starts_at_invalid_value(self):
self.assertRaises(ValueError, Pendulum.set_week_starts_at, 7)

def test_get_week_starts_at(self):
Pendulum.set_week_starts_at(pendulum.TUESDAY)
self.assertEqual(Pendulum.get_week_starts_at(), pendulum.TUESDAY)
Expand Down