Skip to content

fix: handle DST folded dates with start/end_of #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix: handle DST folded dates with start/end_of #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pendulum/datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def set(
tz = self.tz

return self.__class__.create(
year, month, day, hour, minute, second, microsecond, tz=tz
year, month, day, hour, minute, second, microsecond, tz=tz, fold=self.fold
)

@property
Expand Down
40 changes: 40 additions & 0 deletions tests/datetime/test_start_end_of.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,49 @@ def test_start_of_with_transition():
assert d.start_of("year").offset == 3600


def test_start_of_on_date_before_transition():
d = pendulum.datetime(2013, 10, 27, 0, 59, 59, tz="UTC").in_timezone("Europe/Paris")
assert d.offset == 7200
assert d.start_of("minute").offset == 7200
assert d.start_of("hour").offset == 7200
assert d.start_of("day").offset == 7200
assert d.start_of("month").offset == 7200
assert d.start_of("year").offset == 3600


def test_start_of_on_date_after_transition():
d = pendulum.datetime(2013, 10, 27, 1, 59, 59, tz="UTC").in_timezone("Europe/Paris")
assert d.offset == 3600
assert d.start_of("minute").offset == 3600
assert d.start_of("hour").offset == 3600
assert d.start_of("day").offset == 7200
assert d.start_of("month").offset == 7200
assert d.start_of("year").offset == 3600


def test_end_of_with_transition():
d = pendulum.datetime(2013, 3, 31, tz="Europe/Paris")
assert d.offset == 3600
assert d.end_of("month").offset == 7200
assert d.end_of("day").offset == 7200
assert d.end_of("year").offset == 3600


def test_end_of_on_date_before_transition():
d = pendulum.datetime(2013, 10, 27, 0, 0, 0, tz="UTC").in_timezone("Europe/Paris")
assert d.offset == 7200
assert d.end_of("minute").offset == 7200
assert d.end_of("hour").offset == 7200
assert d.end_of("day").offset == 3600
assert d.end_of("month").offset == 3600
assert d.end_of("year").offset == 3600


def test_end_of_on_date_after_transition():
d = pendulum.datetime(2013, 10, 27, 1, 0, 0, tz="UTC").in_timezone("Europe/Paris")
assert d.offset == 3600
assert d.end_of("minute").offset == 3600
assert d.end_of("hour").offset == 3600
assert d.end_of("day").offset == 3600
assert d.end_of("month").offset == 3600
assert d.end_of("year").offset == 3600