-
-
Notifications
You must be signed in to change notification settings - Fork 412
Rewrite extensions in Rust #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
71f7dde
Improve performances by using Rust
sdispater 31bc280
Reorganize Rust code
sdispater 7738765
Improve ISO8601 parsing
sdispater 2f148a3
Implement duration parsing in Rust
sdispater 6b4468a
Reintroduce type accuracy parsing
sdispater 07a037e
Fix parsing of previously supported formats
sdispater ef3e0be
No longer build the _iso8601 extension
sdispater 00ba22d
Fix typing
sdispater a90c1a7
Include the rust directory in the sdist
sdispater 008d5fa
Fix includes in the pyproject file
sdispater cb5d28d
Ensure extensions are compiled in CI
sdispater a5d531a
Optimize build
sdispater f66ac83
Implement the helpers extension in Rust
sdispater aedd96a
Fix parsing without extensions
sdispater d248e4f
Lint Rust code
sdispater 0f785b0
Address review comments
sdispater fdd182a
Make Rust code more idiomatic
sdispater c197c0a
Fix tests and linting following rebase
sdispater d29ce1b
Address review comments
sdispater File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| [build] | ||
| rustflags = [] | ||
|
|
||
| # see https://pyo3.rs/main/building_and_distribution.html#macos | ||
| [target.x86_64-apple-darwin] | ||
| rustflags = [ | ||
| "-C", "link-arg=-undefined", | ||
| "-C", "link-arg=dynamic_lookup", | ||
| ] | ||
|
|
||
| [target.aarch64-apple-darwin] | ||
| rustflags = [ | ||
| "-C", "link-arg=-undefined", | ||
| "-C", "link-arg=dynamic_lookup", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,3 +35,4 @@ setup.py | |
| # editor | ||
|
|
||
| .vscode | ||
| /target | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.