Make instance() support all native types (date, time, datetime)
#732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
CodSpeed Performance ReportMerging #732 will improve performances by 24.36%Comparing Summary
Benchmarks breakdown
|
Co-Authored-By: Chase Sterling <chase.sterling@gmail.com>
sdispater
force-pushed
the
feature/instance-all-types
branch
from
43c4c81 to
e807ca0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
instance()function now accepts 'date',timeordatetimeinstances.This PR also reorganizes the
DateTimecode to make it inheritable, which was not the case due to the usage ofinstance().Fixes #250
Fixes #203
Supersedes #707
Pull Request Check List