Skip to content

Use divmod instead of two lines with // and % #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Use divmod instead of two lines with // and % #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pendulum/_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,8 @@ def local_time(
month -= 1

# Handle hours, minutes, seconds and microseconds
hour = seconds // SECS_PER_HOUR
seconds %= SECS_PER_HOUR
minute = seconds // SECS_PER_MIN
second = seconds % SECS_PER_MIN
hour, seconds = divmod(seconds, SECS_PER_HOUR)
minute, second = divmod(seconds, SECS_PER_MIN)

return year, month, day, hour, minute, second, microseconds

Expand Down
7 changes: 2 additions & 5 deletions pendulum/duration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,12 +500,9 @@ def __new__(
total = abs(self._total)

self._microseconds = round(total % 1 * 1e6)
self._seconds = int(total) % SECONDS_PER_DAY

days = int(total) // SECONDS_PER_DAY
days, self._seconds = divmod(int(total), SECONDS_PER_DAY)
self._days = abs(days + years * 365 + months * 30)
self._remaining_days = days % 7
self._weeks = days // 7
self._weeks, self._remaining_days = divmod(days, 7)
self._months = abs(months)
self._years = abs(years)

Expand Down