Skip to content

Conversation

@botantony
Copy link

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This will add Python 3.14 support. I was able to run make dev && make test successfully (no errors, only 3 warnings and 4 skips) so I assume there was no breaking changes for this project

Related to Homebrew/homebrew-core#250674

This will add Python 3.14 support
Related to Homebrew/homebrew-core#250674

Signed-off-by: botantony <antonsm21@gmail.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #922 will not alter performance

Comparing botantony:update-pyo3-crate (b234f30) with master (3382956)

Summary

✅ 1 untouched

@ashb
Copy link
Member

ashb commented Oct 22, 2025

Looks like we've got some deprecated things to fix now too:

error: use of deprecated method pyo3::types::PyAnyMethods::downcast: use Bound::cast instead

@ashb
Copy link
Member

ashb commented Oct 22, 2025

We should also add py 3.14 to the test matrix (and likely remove 3.9 since that is out of support)

@Secrus
Copy link
Collaborator

Secrus commented Oct 22, 2025

We should also add py 3.14 to the test matrix (and likely remove 3.9 since that is out of support)

Let's not do that all in single PR

Copy link
Collaborator

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the deprecations and changes between 0.25 and 0.27.

"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop that please, let's make this PR focused on what the title says, upgrading PyO3 0.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants