Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove execute bit from setup.py #7760

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 29, 2024

Invoking setup.py directly is deprecated:

Instead, something like pip install -e . or pip install . should be used:

See #5896 and linked PRs for related changes.

@hugovk hugovk added the Cleanup label Jan 29, 2024
@nulano
Copy link
Contributor

nulano commented Jan 29, 2024

Would it be a good idea to also remove the shebang?

#!/usr/bin/env python3

@hugovk
Copy link
Member Author

hugovk commented Jan 29, 2024

Good idea!

Our pre-commit has a "check that executables have shebangs" check, but didn't have the reverse.

So I've added the "check that scripts with shebangs are executable" check and removed the shebangs from some other files. Plus removed the shebang and exec bit from one Tests/check_* file, to match the others.

@radarhere radarhere merged commit 15dc431 into python-pillow:main Jan 30, 2024
53 of 56 checks passed
@hugovk hugovk deleted the rm-exec-bit-setup.py branch January 30, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants