-
Notifications
You must be signed in to change notification settings - Fork 150
Tests for rolling aggregations in cudf. #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This seems to failing on a test that wasn't modified. Could someone please check? |
|
Yes, appears to be due to pandas 0.25. Do you think you can fix it? |
|
Made the fix, hope this works out. |
|
@martindurant Some other error unrelated to the PR popped up, I guess. |
|
Please check on distributed what the correct call to gen_cluster should look like. |
|
I don't think I modified that test. It seems to be a Dask-related test (is a version issue?). I'll try looking into it, although I'm not sure if I have enough knowledge to fix it. |
|
Right - it will be because the upstream signature changed in the meantime. |
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 94.96% 94.71% -0.25%
==========================================
Files 13 13
Lines 1609 1609
==========================================
- Hits 1528 1524 -4
- Misses 81 85 +4
Continue to review full report at Codecov.
|
|
@martindurant Made the fixes. Could you please take a look? Also, it would be great to have the cudf integration using |
|
Hoping to make a release soon |
|
Awesome, thanks! |
Some features are not yet available w.r.t. rolling objects in cudf. Will update the tests once the features are rolled out.