Skip to content

Conversation

@chinmaychandak
Copy link
Contributor

Some features are not yet available w.r.t. rolling objects in cudf. Will update the tests once the features are rolled out.

@chinmaychandak
Copy link
Contributor Author

This seems to failing on a test that wasn't modified. Could someone please check?

@martindurant
Copy link
Member

Yes, appears to be due to pandas 0.25. Do you think you can fix it?

@chinmaychandak
Copy link
Contributor Author

Made the fix, hope this works out.

@chinmaychandak
Copy link
Contributor Author

@martindurant Some other error unrelated to the PR popped up, I guess.

@martindurant
Copy link
Member

Please check on distributed what the correct call to gen_cluster should look like.

@chinmaychandak
Copy link
Contributor Author

chinmaychandak commented Aug 7, 2019

I don't think I modified that test. It seems to be a Dask-related test (is a version issue?). I'll try looking into it, although I'm not sure if I have enough knowledge to fix it.

@martindurant
Copy link
Member

Right - it will be because the upstream signature changed in the meantime.

@codecov-io
Copy link

Codecov Report

Merging #263 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   94.96%   94.71%   -0.25%     
==========================================
  Files          13       13              
  Lines        1609     1609              
==========================================
- Hits         1528     1524       -4     
- Misses         81       85       +4
Impacted Files Coverage Δ
streamz/dataframe/core.py 91.6% <0%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d909429...f97057e. Read the comment docs.

@chinmaychandak
Copy link
Contributor Author

@martindurant Made the fixes. Could you please take a look?

Also, it would be great to have the cudf integration using conda install -c conda-forge streamz. Could one of the maintainers please update the Anaconda package; I think it is outdated w.r.t. the cudf changes?

@martindurant martindurant merged commit df981f9 into python-streamz:master Aug 13, 2019
@martindurant
Copy link
Member

Hoping to make a release soon

@martindurant
Copy link
Member

conda-forge/streamz-feedstock#9

@chinmaychandak
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants