Code with tests #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyaaa86
reviewed
Apr 6, 2021
| @@ -1,3 +1,5 @@ | |||
| [](https://codecov.io/gh/OdintsovTim/level_2_2) | |||
|
|
|||
There was a problem hiding this comment.
suggestion: бейдж из трэвиса тоже стоит добавить
There was a problem hiding this comment.
Зачем?) Как по мне, это точно не является обязательным, плашка о 100% покрытии уже гарант того, что на трэвисе все ок, иначе бы запрос не отправился бы
code/flake_master/run.py
Outdated
| @argument('project_path', type=Path(exists=True)) | ||
| @pass_context | ||
| def upgrade(ctx, project_path): | ||
| def upgrade_preset(ctx, project_path): |
There was a problem hiding this comment.
nitpick: upgrade не обязательно переименовывать, с ней нет таких проблем, как с setup
| ] | ||
| ) | ||
| def test_extract_preset_url(preset_name_or_url_or_path, presets_repo_url, preset_info, expected): | ||
| assert extract_preset_url(preset_name_or_url_or_path, preset_info, presets_repo_url) == expected |
There was a problem hiding this comment.
nitpick: В функции еще идет проверка есть ли вообще preset_name_or_url_or_path, думаю, можно добавить случай, когда строка пустая
|
|
||
|
|
||
| def test_load_preset_from_url(mocker, flake8_preset_factory, row_config_data): | ||
| response = mocker.patch('code.flake_master.utils.preset_fetchers.get', autospe=True) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.