Subprocess is not singleton anymore: only lock property is shared. #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SingleLock` metaclass added. `Singleton` saved for historical reasons. All Subprocess tests and SSHAuth tests ported to pytest. Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
penguinolog
added
bug
penguinolog
added a commit
that referenced
this pull request
Oct 29, 2018
Force to close FIFO buffers instead of waiting for garbage collector (cherry picked from commit c31300c) Rework locks model on exec_result. (#94) Deprecate `ExecResult().lock` property. (cherry picked from commit d4c3a47) [x] partial migration to pytest for parametrized tests [x] Fix no stdin in exec result (cherry picked from commit 038ba13) Subprocess is not singleton anymore: only lock property is shared. (#96) `SingleLock` metaclass added. `Singleton` saved for historical reasons. All Subprocess tests and SSHAuth tests ported to pytest. (cherry picked from commit f120cae)
penguinolog
added a commit
that referenced
this pull request
Oct 29, 2018
[x] partial migration to pytest for parametrized tests [x] Fix no stdin in exec result (cherry picked from commit 038ba13) Subprocess is not singleton anymore: only lock property is shared. (#96) `SingleLock` metaclass added. `Singleton` saved for historical reasons. All Subprocess tests and SSHAuth tests ported to pytest. (cherry picked from commit f120cae) Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
penguinolog
added a commit
that referenced
this pull request
Oct 29, 2018
[x] partial migration to pytest for parametrized tests [x] Fix no stdin in exec result (cherry picked from commit 038ba13) Subprocess is not singleton anymore: only lock property is shared. (#96) `SingleLock` metaclass added. `Singleton` saved for historical reasons. All Subprocess tests and SSHAuth tests ported to pytest. (cherry picked from commit f120cae) Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
penguinolog
added a commit
that referenced
this pull request
Oct 29, 2018
[x] partial migration to pytest for parametrized tests [x] Fix no stdin in exec result (cherry picked from commit 038ba13) Subprocess is not singleton anymore: only lock property is shared. (#96) `SingleLock` metaclass added. `Singleton` saved for historical reasons. All Subprocess tests and SSHAuth tests ported to pytest. (cherry picked from commit f120cae) Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
penguinolog
added a commit
that referenced
this pull request
Oct 29, 2018
[x] partial migration to pytest for parametrized tests [x] Fix no stdin in exec result (cherry picked from commit 038ba13) Subprocess is not singleton anymore: only lock property is shared. (#96) `SingleLock` metaclass added. `Singleton` saved for historical reasons. All Subprocess tests and SSHAuth tests ported to pytest. (cherry picked from commit f120cae) Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SingleLockmetaclass added.Singletonsaved for historical reasons.All Subprocess tests and SSHAuth tests ported to pytest.