Skip to content

feat: optimize incoming parser by reducing call stack#1116

Merged
bdraco merged 3 commits intomasterfrom
reduce_stack
Dec 18, 2022
Merged

feat: optimize incoming parser by reducing call stack#1116
bdraco merged 3 commits intomasterfrom
reduce_stack

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Dec 18, 2022

This is a ~4% speed up

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 18, 2022

Codecov Report

Base: 99.95% // Head: 99.72% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (272a5b0) compared to base (524ae89).
Patch coverage: 98.24% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
- Coverage   99.95%   99.72%   -0.24%     
==========================================
  Files          21       22       +1     
  Lines        2459     2561     +102     
  Branches      443      452       +9     
==========================================
+ Hits         2458     2554      +96     
- Misses          0        5       +5     
- Partials        1        2       +1     
Impacted Files Coverage Δ
src/zeroconf/_cache.py 100.00% <ø> (ø)
src/zeroconf/_core.py 100.00% <ø> (ø)
src/zeroconf/_exceptions.py 100.00% <ø> (ø)
src/zeroconf/_history.py 100.00% <ø> (ø)
src/zeroconf/_logger.py 100.00% <ø> (ø)
src/zeroconf/_utils/name.py 98.36% <ø> (ø)
src/zeroconf/_utils/time.py 100.00% <ø> (ø)
src/zeroconf/const.py 97.36% <ø> (ø)
src/zeroconf/_protocol/incoming.py 98.84% <96.82%> (ø)
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review December 18, 2022 02:26
@bdraco bdraco merged commit 11f3f0e into master Dec 18, 2022
@bdraco bdraco deleted the reduce_stack branch December 18, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants