gh-100673: Removed erroneous note in the get_type_hints docs#100701
gh-100673: Removed erroneous note in the get_type_hints docs#100701AlexWaygood merged 1 commit intopython:mainfrom
Conversation
typing.get_type_hints still includes base class type hints.
FrozenBob
requested review from
AlexWaygood,
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
|
All commit authors signed the Contributor License Agreement. |
There was a problem hiding this comment.
Thank you! cc @JelleZijlstra @sobolevn as reviewer of #99990
hauntsaninja
added
needs backport to 3.10
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me. I confirmed that, despite the behaviour of __annotations__ changing between 3.9 and 3.10, there was no behaviour change to get_type_hints between 3.9 and 3.10. (Cc. @MonadChains, as the author of #99990, and @sobolevn, who suggested adding the note to the get_type_hints docs.)
|
Thanks @FrozenBob for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Sorry, @FrozenBob and @AlexWaygood, I could not cleanly backport this to |
|
GH-100823 is a backport of this pull request to the 3.11 branch. |
…ythonGH-100701) Removed erroneous note in the get_type_hints docs typing.get_type_hints still includes base class type hints. (cherry picked from commit deaf090) Co-authored-by: FrozenBob <30644137+FrozenBob@users.noreply.github.com>
|
Yeah, I still think that adding a note about |
…ython#100701) Removed erroneous note in the get_type_hints docs typing.get_type_hints still includes base class type hints. (cherry picked from commit deaf090)
|
GH-100826 is a backport of this pull request to the 3.10 branch. |
7 participants
typing.get_type_hints still includes base class type hints, contrary to a note in the docs claiming this was changed in Python 3.10. The note was a mistake. This PR removes the incorrect note.