Improve code examples in typing.rst#105346
Merged
AlexWaygood merged 4 commits intopython:mainfrom Jun 7, 2023
Merged
Conversation
AlexWaygood
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
bedevere-bot
added
awaiting core review
docs
AlexWaygood
commented
Jun 6, 2023
AlexWaygood
added
needs backport to 3.11
Member
Author
JelleZijlstra
approved these changes
Jun 7, 2023
Contributor
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Contributor
|
Sorry, @AlexWaygood, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2023
(cherry picked from commit 81c8132) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
GH-105422 is a backport of this pull request to the 3.12 branch. |
|
GH-105427 is a backport of this pull request to the 3.11 branch. |
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Jun 7, 2023
JelleZijlstra
pushed a commit
that referenced
this pull request
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. testcode::directives to make sure they don't regress... doctest::directives to all REPL examples that pass, to make sure they continue to pass in the future... testcode::directives to the code examples forget_argsandget_origin, so the assertions we already have in those examples are tested in CI.get_type_hintsandis_typeddict, and test these assertions using the.. testcode::directive.📚 Documentation preview 📚: https://cpython-previews--105346.org.readthedocs.build/