Skip to content

Conversation

@apurvakhatri
Copy link
Contributor

@apurvakhatri apurvakhatri commented Aug 25, 2023

Signed-off-by: apurvakhatri <khatri.ap@northeastern.edu>
@ghost

This comment was marked as resolved.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 25, 2023
@Eclips4

This comment was marked as outdated.

@Eclips4 Eclips4 closed this Aug 25, 2023
@AA-Turner

This comment was marked as outdated.

@AA-Turner AA-Turner reopened this Aug 25, 2023
@AA-Turner AA-Turner changed the title Fix issue 108202 gh-108202: Document prweek and mdays Aug 25, 2023
@AlexWaygood AlexWaygood changed the title gh-108202: Document prweek and mdays gh-108202: calendar: Document prweek and mdays Aug 25, 2023
@AA-Turner
Copy link
Member

@apurvakhatri please could you split this PR into two parts? We haven't discussed if we want to document mdays, so having both in one PR makes it difficult to review.

A

@apurvakhatri
Copy link
Contributor Author

Sure, will do that! Should I create a new PR or just remove mdays from this PR request?

@AA-Turner
Copy link
Member

The latter is likely easier. Perhaps also consider documenting all prweek() instances in this PR, rather than just TextCalendar.prweek().

A

@Eclips4

This comment was marked as outdated.

Signed-off-by: apurvakhatri <apurvakhatri2011@gmail.com>
@AA-Turner
Copy link
Member

@apurvakhatri please avoid force pushes, see the devguide:

Your pull request may involve several commits as a result of addressing code review comments. Please keep the commit history in the pull request intact by not squashing, amending, or anything that would require a force push to GitHub. A detailed commit history allows reviewers to view the diff of one commit to another so they can easily verify whether their comments have been addressed. The commits will be squashed when the pull request is merged.

@AA-Turner
Copy link
Member

Please also restrict this PR to just prweek(), as discussed.

Signed-off-by: apurvakhatri <apurvakhatri2011@gmail.com>
@AA-Turner AA-Turner changed the title gh-108202: calendar: Document prweek and mdays gh-108202: calendar: Document prweek Sep 6, 2023
@AA-Turner AA-Turner changed the title gh-108202: calendar: Document prweek gh-108202: calendar: Document prweek Sep 6, 2023
hugovk

This comment was marked as resolved.

@bedevere-app
Copy link

bedevere-app bot commented Aug 15, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hugovk hugovk added the pending The issue will be closed if no feedback is provided label Sep 5, 2024
@StanFromIreland

This comment was marked as resolved.

@hugovk hugovk enabled auto-merge (squash) December 8, 2025 09:54
@hugovk hugovk merged commit 8620d30 into python:main Dec 8, 2025
31 of 32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir pending The issue will be closed if no feedback is provided skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants