bpo-26704: Add test for double patching instance methods#11085
Merged
cjw296 merged 1 commit intopython:masterfrom Dec 12, 2018
Merged
bpo-26704: Add test for double patching instance methods#11085cjw296 merged 1 commit intopython:masterfrom
cjw296 merged 1 commit intopython:masterfrom
Conversation
tirkarthi
approved these changes
Dec 11, 2018
Member
tirkarthi
left a comment
tirkarthi
left a comment
There was a problem hiding this comment.
LGTM. I will wait for someone else to look at this and also the patch in bpo to see if I am missing anything. Thanks for the PR 👍
cjw296
reviewed
Dec 11, 2018
Contributor
Author
|
Ahhhhh this would have been a perfect use of github's new "suggested changes" feature 😆. I'll get to these when I'm at a computer instead :) |
Contributor
Author
|
fixed! |
Contributor
|
Nice work! |
|
@cjw296: Please replace |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 12, 2018
(cherry picked from commit 5a718e9) Co-authored-by: Anthony Sottile <asottile@umich.edu>
|
GH-11126 is a backport of this pull request to the 3.7 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cannot be backported past python3.7 as the bugfix was not backported to python3.6)
https://bugs.python.org/issue26704