gh-112066: Use PyDict_SetDefaultRef in place of PyDict_SetDefault.
#112211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
approved these changes
Nov 27, 2023
Member
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
+1 from me; IMO the chance of C-API WG having objections is low enough, let's be optimistic and merge this.
Python/compile.c
Outdated
Comment on lines
986
to
990
| if (res < 0) { | ||
| Py_DECREF(key); | ||
| return NULL; | ||
| } | ||
| if (res == 1) { |
Member
There was a problem hiding this comment.
Maybe merge them in single test != 0?
Contributor
Author
There was a problem hiding this comment.
Thanks - I combined the cases.
…fault`. This changes a number of internal usages of `PyDict_SetDefault` to use `PyDict_SetDefaultRef`.
colesbury
force-pushed
the
PyDict_SetDefaultRef-usage
branch
from
3899746 to
14a00f4
Compare
colesbury
requested review from
iritkatriel,
markshannon and
methane
as code owners
Contributor
Author
|
I've rebased this PR now that #112123 is merged. @serhiy-storchaka, would you please look over this? |
erlend-aasland
approved these changes
Feb 7, 2024
serhiy-storchaka
approved these changes
Feb 7, 2024
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Member
|
Nice change, it makes the code more readable. |
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…fault`. (python#112211) This changes a number of internal usages of `PyDict_SetDefault` to use `PyDict_SetDefaultRef`. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a number of internal usages of
PyDict_SetDefaultto usePyDict_SetDefaultRef.PyDict_SetDefaultthat returns a new reference (instead of a borrowed reference) #112066