gh-112740: Removed buffer size limit for AF_RDS #116652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preset buffer length threshold of 1024 bytes falls short for AF_RDS sockets because each RDS connection has a minimum size of 92 bytes. This limitation restricts us to managing merely around 1024/92 ~ 11 connections. In practical terms, this is inadequate, considering there are machines that manage hundreds of connections. This patch addresses the issue by initially setting the buflen argument to 0 when calling getsockopt function, which consequently returns the necessary buffer length. Subsequently, a buffer of the returned size is created for the next getsockopt call, allowing us to retrieve the full buffer without being constrained by the threshold limit. In addition, the existing implementation overlooks the return value from the kernel's getsockopt function. However, this return value is critical for decoding the buffer data emanating from the AF_RDS sockets. To address this, I propose a solution that involves appending the return value to the buffer specifically for AF_RDS sockets. Signed-off-by: Mohith Kumar Thummaluru <mohith.k.kumar.thummaluru@oracle.com>
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
The preset buffer length threshold of 1024 bytes falls short for AF_RDS sockets because each RDS connection has a minimum size of 92 bytes. This limitation restricts us to managing merely around 1024/92 ~ 11 connections. In practical terms, this is inadequate, considering there are machines that manage hundreds of connections. This patch addresses the issue by initially setting the buflen argument to 0 when calling getsockopt function, which consequently returns the necessary buffer length. Subsequently, a buffer of the returned size is created for the next getsockopt call, allowing us to retrieve the full buffer without being constrained by the threshold limit. In addition, the existing implementation overlooks the return value from the kernel's getsockopt function. However, this return value is critical for decoding the buffer data emanating from the AF_RDS sockets. To address this, I propose a solution that involves appending the return value to the buffer specifically for AF_RDS sockets. Signed-off-by: Mohith Kumar Thummaluru <mohith.k.kumar.thummaluru@oracle.com>
Author
|
Hi, Could you please let me know if there are any comments. |
ZeroIntensity
requested changes
Jul 8, 2024
mohith-kumar-thummaluru
changed the title
ZeroIntensity
requested changes
Jul 10, 2024
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Some general formatting nitpicks -- it's good to go for PEP 7 compliance on new code.
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Member
|
Not sure why CI is failing all of a sudden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preset buffer length threshold of
1024bytes falls short forAF_RDSsockets because each RDS connection has a minimum size of92bytes. This limitation restricts us to managing merely around1024/92 ~ 11connections. In practical terms, this is inadequate, considering there are machines that manage hundreds of connections.This patch addresses the issue by initially setting the
buflenargument to0when callinggetsockopt(), which consequently returns the necessary buffer length. Subsequently, a buffer of the returned size is created for the nextgetsockopt()call, allowing us to retrieve the full buffer without being constrained by the threshold limit.In addition, the existing implementation overlooks the return value from the kernel's getsockopt function. However, this return value is critical for decoding the buffer data emanating from the
AF_RDSsockets. To address this, I propose a solution that involves appending the return value to the buffer specifically forAF_RDSsockets.sock_getsockopt#112740