bpo-35918: Remove broken has_key method and add test #11819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giampaolo
reviewed
Feb 11, 2019
giampaolo
approved these changes
Feb 11, 2019
Contributor
giampaolo
left a comment
giampaolo
left a comment
There was a problem hiding this comment.
LGTM. Thanks for taking care of this.
|
@giampaolo: Please replace |
Contributor
|
Thanks @remilapeyre for the PR, and @giampaolo for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2019
(cherry picked from commit a31f4cc) Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
|
GH-11824 is a backport of this pull request to the 3.7 branch. |
giampaolo
pushed a commit
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35918