Skip to content

bpo-36176: Fix IDLE autocomplete & calltip popup colors.#12262

Merged
terryjreedy merged 1 commit intopython:masterfrom
terryjreedy:colors
Mar 11, 2019
Merged

bpo-36176: Fix IDLE autocomplete & calltip popup colors.#12262
terryjreedy merged 1 commit intopython:masterfrom
terryjreedy:colors

Conversation

@terryjreedy
Copy link
Copy Markdown
Member

@terryjreedy terryjreedy commented Mar 10, 2019

Prevent conflicts with Linux dark themes
(and slightly darken calltip background).

https://bugs.python.org/issue36176

Prevent conflicts with Linux dark themes
(and slightly darken calltip background).
Copy link
Copy Markdown
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu Gnome light and dark and KDE light and dark and the autocomplete and calltips are viewable on all 4 combinations.

@terryjreedy terryjreedy merged commit 491ef53 into python:master Mar 11, 2019
@bedevere-bot
Copy link
Copy Markdown

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@terryjreedy terryjreedy deleted the colors branch March 11, 2019 00:18
@bedevere-bot
Copy link
Copy Markdown

GH-12269 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2019
)

Prevent conflicts with Linux dark themes
(and slightly darken calltip background).
(cherry picked from commit 491ef53)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Mar 11, 2019
Prevent conflicts with Linux dark themes
(and slightly darken calltip background).
(cherry picked from commit 491ef53)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants