[3.13] Add debug offsets for free threaded builds (GH-123041)#123055
Merged
pablogsal merged 2 commits intopython:3.13from Aug 18, 2024
Merged
[3.13] Add debug offsets for free threaded builds (GH-123041)#123055pablogsal merged 2 commits intopython:3.13from
pablogsal merged 2 commits intopython:3.13from
Conversation
(cherry picked from commit d7a3df9) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Member
|
CC @Yhg1s This patch adds more offsets to allow debuggers to work with free threaded builds by exposing fields that can change between the two and making identification of the GIL easier. It also ensures the cookie is only in one place in the binary because we have two copies of it currently due to how we handle initialization. |
Member
|
The ABI file needs to be regenerated because the PyRuntimeState structure had changed but note that the ABI has not changed since this field is always passed as a pointer and its size is not really public (the check doesn't now it). If you are okey with the change I can regenerate the file and update the PR |
Member
|
Yeah, this seems fine to go into rc2. |
Yhg1s
approved these changes
Aug 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit d7a3df9)
Co-authored-by: Pablo Galindo Salgado Pablogsal@gmail.com