Skip to content

gh-124402: Require cpu resource in test_free_threading#124438

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:test_free_threading
Sep 24, 2024
Merged

gh-124402: Require cpu resource in test_free_threading#124438
vstinner merged 1 commit intopython:mainfrom
vstinner:test_free_threading

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 24, 2024 •
edited by bedevere-app bot
Loading

Require the 'cpu' test resource on slow test_free_threading tests.

@vstinner
pythongh-124402: Require cpu resource in test_free_threading
b1c4e2f 
Require the 'cpu' test resource on slow test_free_threading tests.
@vstinner vstinner added skip news needs backport to 3.13 bugs and security fixes labels Sep 24, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 24, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Sep 24, 2024
@vstinner
Copy link
Member Author

vstinner commented Sep 24, 2024 •
edited
Loading

@terryjreedy: With this change, test_free_threading takes 5 seconds instead of 5 to 9 minutes.

cc @colesbury @serhiy-storchaka

I used --junit-xml option to measure how much time takes each test and skipped tests taking longer than 1 second on Windows.

serhiy-storchaka
serhiy-storchaka approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 38a5beb into python:main Sep 24, 2024
@vstinner vstinner deleted the test_free_threading branch September 24, 2024 14:33
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 24, 2024

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 24, 2024

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 38a5beb12a64461a06b84fab285944ecb66de04c 3.13

vstinner added a commit to vstinner/cpython that referenced this pull request Sep 24, 2024
@vstinner
pythongh-124402: Require cpu resource in test_free_threading (python#…
17555f5 
…124438)

Require the 'cpu' test resource on slow test_free_threading tests.

(cherry picked from commit 38a5beb)
@bedevere-app
Copy link

bedevere-app bot commented Sep 24, 2024

GH-124439 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 24, 2024
Yhg1s pushed a commit that referenced this pull request Sep 24, 2024
@vstinner
[3.13] gh-124402: Require cpu resource in test_free_threading (#124438)…
5615351 
… (#124439)

gh-124402: Require cpu resource in test_free_threading (#124438)

Require the 'cpu' test resource on slow test_free_threading tests.

(cherry picked from commit 38a5beb)
@colesbury
Copy link
Contributor

colesbury commented Sep 24, 2024

@vstinner - Please slow down with these changes. Marking these tests as cpu makes them much less useful because they do not run on PRs in GitHub CI.

As I wrote on the original issue, we should be reducing the number of iterations and the number of threads so that they can run quickly.

@vstinner
Copy link
Member Author

vstinner commented Sep 24, 2024

I replied on the issue: #124402 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@vstinner vstinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @colesbury @serhiy-storchaka