Assertion failure on finalization with `_lsprof` and `asyncio` in 3.12

[devdanzin]

Crash report

What happened?

It's possible to abort the interpreter in 3.12 during finalization by having a mix of enabled _lsprof and asyncio with very specific details:

import asyncio
import _lsprof

obj = _lsprof.Profiler()
obj.enable()
obj._pystart_callback(lambda: 0, 0)
obj = None  # Required

loop = asyncio.get_event_loop()

Not having loop stored in a variable or not reassigning obj breaks the testcase.
Abort message:

python: Python/instrumentation.c:958: call_instrumentation_vector: Assertion `instrumentation_cross_checks(tstate->interp, code)' failed.
Aborted

Found using fusil by @vstinner.

CPython versions tested on:

3.12

Operating systems tested on:

Linux

Output from running 'python -VV' on the command line:

Python 3.12.8+ (heads/3.12:b0615a8a9aa, Dec 11 2024, 13:46:42) [GCC 11.4.0]

[graingert]

Can you repeat this with asyncio.new_event_loop()?

[devdanzin]

It fails with the same message.

[ZeroIntensity]

The reproducer seems to pass just fine on release builds. I suspect that the assertion just needs to get removed.

[gaogaotiantian]

No please do not just remove random assertions. That assertion indicates that on that specific code object, the monitoring events are not consistent. We should figure out why.

[gaogaotiantian]

Hmm, it seems to be fine with main branch as well. @devdanzin does it only repro on 3.12?

[devdanzin]

Yes, I was only able to hit the assertion failure in 3.12.

[gaogaotiantian]

Hmm, if it's fixed somehow in 3.13, and it's a very rare issue (only the assertion failure, no observable problem with released branch), it's probably not worth it to investigate it. (It's pretty close to the last bug-fix release for 3.12 too).

[ZeroIntensity]

Should we just close this, then?

[gaogaotiantian]

I'm inclined to close this, unless others disagree.