-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-127930: use explicit imports in tkinter.simpledialog #127931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I hope, no one does |
|
I added |
Misc/NEWS.d/next/Library/2024-12-14-19-51-39.gh-issue-127930.WsGnh9.rst
Outdated
Show resolved
Hide resolved
…sGnh9.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
LGTM. 👍 |
…#127931) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
simpledialog was overlooked when all the other tkinter submodules were updated to use explicit imports in #14864. This MR fixes that.
This is relevant to typeshed, where stubtest detects the extra constants imported into tkinter.simpledialog and emits a warning that they're not present in the stubs. Star imports in the stdlib usually indicate an intention to re-export.
I don't think this is user-facing enough to need a NEWS entry, but I'm happy to add one if anyone thinks otherwise.