gh-129393: Make 'sys.platform' return "freebsd" only on FreeBSD witho…#129394
gh-129393: Make 'sys.platform' return "freebsd" only on FreeBSD witho…#129394vstinner merged 1 commit intopython:mainfrom
Conversation
|
FWIW: I am a FreeBSD committer as well. |
7cecc55 to
242840a
Compare
|
cc @vstinner as the FreeBSD contact |
|
LGTM. Hopefully there's not too much fallout. |
Me as well, but this should stay on 3.14 and not be backported, even if I'd like to see that. |
|
IMO this change is backward compatible since it was recommended to use |
|
We did the same change on Linux when Linux was upgrade from Linux 2.x to Linux 3.x, and it went fine. |
Oh great, I'd love to see this backported! |
242840a to
b9062bb
Compare
That would be backward incompatible, it's a bad idea. This change can only land into Python 3.14. |
I am confused, doesn't this contract your previous statement: #129394 (comment)? |
|
Code "should" be checking |
That's correct and this is what I have noticed with |
|
Is there anything required from me to merge this one? |
… without major version
b9062bb to
0f19207
Compare
|
Merged, thank you @michael-o. |
Thank you very much for the quick turnaround. Always a pleasure to work with pros! |
…python#129394) Make 'sys.platform' return "freebsd" only on FreeBSD without major version.
…ut major version
Result:
📚 Documentation preview 📚: https://cpython-previews--129394.org.readthedocs.build/